[Webkit-unassigned] [Bug 55095] IndexedDB: fire versionchange events when calling setVersion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55095





--- Comment #13 from Jeremy Orlow <jorlow at chromium.org>  2011-03-01 19:08:29 PST ---
(In reply to comment #11)
> (From update of attachment 84099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84099&action=review
> 
> >> Source/WebCore/storage/IDBDatabase.h:90
> >> +    virtual bool dispatchEvent(PassRefPtr<Event>);
> > 
> > usually we dont' interleave virtual and non-virtual...but this is going away anyway
> 
> I kept it around to help make multi-process and single-process chrome do the same things.

Why was this necessary.  In the future, when you hit stuff that might require a complicated workaround like this, please just ask before writing the code...and explain somewhere why you did what you did.  (Probably in the change log and here.)

> >> Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp:102
> >> +    // use saved callbacks
> > 
> > Use full sentences.  Don't say what you're doing, say why.
> 
> D'oh sorry, I meant to flesh this out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.