[Webkit-unassigned] [Bug 55095] IndexedDB: fire versionchange events when calling setVersion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 18:52:58 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55095





--- Comment #11 from David Grogan <dgrogan at chromium.org>  2011-03-01 18:52:59 PST ---
(From update of attachment 84099)
View in context: https://bugs.webkit.org/attachment.cgi?id=84099&action=review

>> Source/WebCore/storage/IDBDatabase.h:90
>> +    virtual bool dispatchEvent(PassRefPtr<Event>);
> 
> usually we dont' interleave virtual and non-virtual...but this is going away anyway

I kept it around to help make multi-process and single-process chrome do the same things.

>> Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp:102
>> +    // use saved callbacks
> 
> Use full sentences.  Don't say what you're doing, say why.

D'oh sorry, I meant to flesh this out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list