[Webkit-unassigned] [Bug 42484] Support localized numbers in <input type=number>

Tue Mar 1 15:28:58 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=42484

Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84179|review?                     |review+
               Flag|                            |

--- Comment #17 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-03-01 15:28:58 PST ---
(From update of attachment 84179)
View in context: https://bugs.webkit.org/attachment.cgi?id=84179&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:5665
> +		F5CC42DC12F801CA00D5F7E3 /* LocalizedNumberMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = F5CC42DB12F801CA00D5F7E3 /* LocalizedNumberMac.mm */; };

Did you run sort-Xcode-project-file after your changes? This file looks out of order.

> Source/WebCore/platform/text/mac/LocalizedNumberMac.mm:58
> +    NSNumberFormatter* formatter = [[[NSNumberFormatter alloc] init] autorelease];

I don't know how this stuff works. Can you check with ObJC-heads before landing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.