[Webkit-unassigned] [Bug 54926] All Console Messages should be passed to ChromeClients.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54926


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83676|review?                     |review+
               Flag|                            |




--- Comment #17 from Timothy Hatcher <timothy at apple.com>  2011-03-01 10:27:45 PST ---
(From update of attachment 83676)
View in context: https://bugs.webkit.org/attachment.cgi?id=83676&action=review

r+ if you add the Web prefix to the strings.

> Source/WebKit/mac/WebView/WebUIDelegatePrivate.h:119
> +extern NSString *ConsoleMessageHTMLMessageSource;
> +extern NSString *ConsoleMessageWMLMessageSource;
> +extern NSString *ConsoleMessageXMLMessageSource;
> +extern NSString *ConsoleMessageJSMessageSource;
> +extern NSString *ConsoleMessageCSSMessageSource;
> +extern NSString *ConsoleMessageOtherMessageSource;
> +
> +// Message Types.
> +extern NSString *ConsoleMessageLogMessageType;
> +extern NSString *ConsoleMessageObjectMessageType;
> +extern NSString *ConsoleMessageTraceMessageType;
> +extern NSString *ConsoleMessageStartGroupMessageType;
> +extern NSString *ConsoleMessageStartGroupCollapsedMessageType;
> +extern NSString *ConsoleMessageEndGroupMessageType;
> +extern NSString *ConsoleMessageAssertMessageType;
> +extern NSString *ConsoleMessageUncaughtExceptionMessageType;
> +extern NSString *ConsoleMessageNetworkErrorMessageType;
> +
> +// Message Levels.
> +extern NSString *ConsoleMessageTipMessageLevel;
> +extern NSString *ConsoleMessageLogMessageLevel;
> +extern NSString *ConsoleMessageWarningMessageLevel;
> +extern NSString *ConsoleMessageErrorMessageLevel;
> +extern NSString *ConsoleMessageDebugMessageLevel;

Sorry I didn't catch this earlier, but these need a "Web" prefix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.