[Webkit-unassigned] [Bug 55453] Pass preferred language information down to font fallback logic

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 10:24:05 PST 2011


--- Comment #3 from Adam Langley <agl at chromium.org>  2011-03-01 10:24:04 PST ---
(From update of attachment 84205)
View in context: https://bugs.webkit.org/attachment.cgi?id=84205&action=review

> WebKit/chromium/public/gtk/WebFontInfo.h:48
> +    //   preferredLanguage: preferred language for the characters

The comment should specify the format of the language. There are (at least) two and three letter forms in use.

> WebKit/chromium/public/linux/WebSandboxSupport.h:-53
> -    virtual WebString getFontFamilyForCharacters(const WebUChar* characters, size_t numCharacters) = 0;

the indentation here looks to be wrong.

> WebCore/platform/graphics/chromium/FontCacheLinux.cpp:61
> +    icu::Locale locale = icu::Locale::getDefault();

If this is for Linux then is the best way to get the locale? In zygote_main_linux.cc we preload the ICU timezone information, but I don't see anything about locale. So, if ICU tries to access the disk for this then it'll fail.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list