[Webkit-unassigned] [Bug 25533] Elements on the same line should be treated as such by caret navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25533


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77809|0                           |1
        is obsolete|                            |
  Attachment #84236|                            |review?
               Flag|                            |




--- Comment #13 from Mario Sanchez Prada <msanchez at igalia.com>  2011-03-01 09:04:19 PST ---
Created an attachment (id=84236)
 --> (https://bugs.webkit.org/attachment.cgi?id=84236&action=review)
Patch proposal + Layout test

Attaching a new patch that doesn't present the problems stated by Joanie, although we still need to fix another bug I found while working on this one that is causing trouble with other issues related to vertical movement of the caret (see below)...

(In reply to comment #10)
> [...]
> Mario, when re-testing your change for this bug with the test case I
> mentioned in #a11y, I discovered that your patch impacts it. Therefore
> maybe this (and my previous comment about skipping lines on Ubuntu) is
> the same issue after all.

Yep, it certainly was :-)

> To use this test case, enable caret navigation. Then Tab/Shift+Tab into
> focus is on the 'Start here' link at the top of the page. Start Down
> Arrowing.
> 
> Without your patch, I get stuck on every instance of the 'bla' link.
> I cannot Down Arrow off of it. If I Right Arrow once to move off of the
> link and then Down Arrow, I move to the end of the line.
>
> With your patch, I only get stuck on the first instance of the 'bla'
> link. I still cannot Down Arrow off of it. But if I Right Arrow once
> to move off of the link and then Down Arrow, I jump to the very end
> of the document.

You were right, I found there was a "different wrong behaviour" with my patch that was not happening without it (still wrong, though), but I found it to be a different bug I'll be reporting in some minutes, right after posting this comment. Also (and that's why I mention this here), I'll be making that new bug blocking this one, since it definitely impacts vertical caret navigation as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.