[Webkit-unassigned] [Bug 63674] Get webkit to compile with USE(CFNETWORK) enabled on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63674





--- Comment #5 from Pratik Solanki <psolanki at apple.com>  2011-06-30 16:04:50 PST ---
(From update of attachment 99195)
View in context: https://bugs.webkit.org/attachment.cgi?id=99195&action=review

Thanks for looking at this!

>>> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:220
>>> +        CFURLResponseSetMIMEType(cfResponse, CFSTR("text/html"));
>> 
>> This seemed like a change in behavior to until I looked in ResourceHandleMac.mm and saw the NSURLResponse version of this code. A note in the ChangeLog about why this was added would have cleared this up.
> 
> It'd be even nicer to share this with the Mac rather than duplicating it. The Mac port could do this in terms of CF API and toll-free bridging should ensure that the NSURLResponse has the right changes.

Yes thats a good idea. I can refactor the code so its shared between the two implementations.

>> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:831
>> +        request = nullRequest;
> 
> Can this be done with a cast instead of creating a new local?

I had it as a cast in an older patch for bug 51836 but Darin suggested I use a local variable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.