[Webkit-unassigned] [Bug 63553] SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63553





--- Comment #6 from Dirk Schulze <krit at webkit.org>  2011-06-30 10:45:58 PST ---
(From update of attachment 99330)
View in context: https://bugs.webkit.org/attachment.cgi?id=99330&action=review

> Source/WebCore/ChangeLog:10
> +        When the animation stops before reaching the end, the elapsed time is bigger than
> +        m_intervalEnd and smaller than simpleDuration. In that case, the progress of
> +        the animation doesn't 100%, it should be the value of the stop point.

Can you go a bit more into detail? I don't understand what you try to fix. What do the timings mean? To review the patch I have to know more about what we try to do here.

> Source/WebCore/svg/animation/SVGSMILElement.cpp:829
> +        activeTime = m_intervalEnd;

Why do you set activeTime here, we haven't done it before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.