[Webkit-unassigned] [Bug 63465] Links to crash logs on TestFailures page should include the crashing symbol (like links in results.html do)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63465





--- Comment #5 from Adam Roben (:aroben) <aroben at apple.com>  2011-06-30 08:22:06 PST ---
(From update of attachment 99304)
View in context: https://bugs.webkit.org/attachment.cgi?id=99304&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:36
>>              if (cachedData.version === currentCachedDataVersion) {
> 
> Shouldn't this be (cachedData.version >= 1)?  Or do you only want to use the cached version if it's up-to-date?

I only want to use the cached data if it matches the current version. Otherwise the cached object might not have all the data we want.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:76
>> +                            result.crashingSymbol = match[1];
> 
> You don't want to break out of the for loop here when you get a match?  Or do you want the last symbol to "win"?

Breaking out sounds good. I'll do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.