[Webkit-unassigned] [Bug 63381] [GTK] [WK2] Implement missing initializeLogChannel function.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63381





--- Comment #4 from Lukasz Slachciak <l.slachciak at samsung.com>  2011-06-30 06:39:37 PST ---
(From update of attachment 98589)
View in context: https://bugs.webkit.org/attachment.cgi?id=98589&action=review

>> Source/WebKit2/Platform/Logging.cpp:48
>> +WTFLogChannel* getChannelFromName(const String& channelName)
> 
> Why not just put this in LoggingGtk and make it static?

I put this function here because I think that in future other ports will want to use it too.
In WebCore, similar function is used by GTK, EFL, QT, WX

>> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:44
>> +    // unfortunatelly this is initialized and enumerated for every WTFLogChannel
> 
> This seems like an expensive thing to do for every log channel. Why not just do it statically?

ok, done. I was thinking about it earlier but was afraid about keeping in memory things till the end. But we will do this only in case of !LOG_DISABLED so this shouldn't be a problem.

>> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:45

> 
> I would prefer you to do this with WTF::String instead of GLib. You can avoid manual memory management that way.

done

>> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:56
>> +#endif /* !LOG_DISABLED */
> 
> C++ style comment here, I think.

Right. Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.