[Webkit-unassigned] [Bug 40447] Infinite loop in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40447


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99278|review?                     |review-
               Flag|                            |




--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2011-06-30 06:21:58 PST ---
(From update of attachment 99278)
View in context: https://bugs.webkit.org/attachment.cgi?id=99278&action=review

> Source/WebCore/ChangeLog:5
> +        Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

Please add WebInspector: prefix.

> LayoutTests/ChangeLog:5
> +        Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

Ditto

> LayoutTests/inspector/editor/text-editor-model-replace-tabs.html:12
> +    	var input = testCases[i];

weird indent, otherwise looks good.

> LayoutTests/inspector/editor/text-editor-model-replace-tabs.html:22
> +    var bufT = [];

nit: no abbreviations in webkit (bufferT & bufferS)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.