[Webkit-unassigned] [Bug 40447] Infinite loop in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40447


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99255|review?                     |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2011-06-30 01:48:06 PST ---
(From update of attachment 99255)
View in context: https://bugs.webkit.org/attachment.cgi?id=99255&action=review

> Source/WebCore/ChangeLog:5
> +        Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

Web Inspector: prefix missing

> LayoutTests/ChangeLog:5
> +        Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded

ditto

> LayoutTests/inspector/editor/text-editor-model-replace-tabs-expected.txt:16
> +[]

It'd be nicer to print results side by side with the source lines. You should also render tab as \t in the source to avoid possible confusions (I have tab rendered as 8 spaces in my settings).

> LayoutTests/inspector/editor/text-editor-model-replace-tabs.html:35
> +            result = "FAIL: time limit (100ms) exceeded (execution time: " + duration + "ms)"

This won't work on the bots. Things may take seconds there. Please do not test performance in the layout tests - they become flaky. As we agree, measuring correctness is sufficient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.