[Webkit-unassigned] [Bug 63395] [WebKit2] Add logging initialization for WebProcess

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63395





--- Comment #5 from Eric Seidel <eric at webkit.org>  2011-06-30 01:08:29 PST ---
(From update of attachment 98619)
View in context: https://bugs.webkit.org/attachment.cgi?id=98619&action=review

>>> Source/WebKit2/ChangeLog:8
>>> +        Logging initialization was added for WebProcess. Similar initialization is already done for UIProcess.
>> 
>> Watch out for 80-column limit on changelogs.
> 
> Ok, I'll fix this

This is incorrect advice.

>>> Source/WebKit2/WebProcess/WebProcess.cpp:143
>>> +#if !LOG_DISABLED
>> 
>> I haven't seen this idiom lately on WebKit -- wouldn't it be better if it were an ENABLE(LOGGING) macro call?
> 
> In mac port it is commonly used in Webkit and WebKit2, using ENABLE(LOGGING) would require defining LOGGING feature in Platform.h
> in WebCore it is commonly used.
> grep -r "\!LOG_DISABLED" Source/ | wc -l
> shows me 89 occurences

You are correct !LOG_DISABLED Is how the check is written.  The logging code is very old and crufty.  As far as I can tell it's not used much these days.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.