[Webkit-unassigned] [Bug 63583] Web Inspector fails to display source for eval with syntax error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63583


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99162|review?                     |review-
               Flag|                            |




--- Comment #6 from Geoffrey Garen <ggaren at apple.com>  2011-06-29 15:52:13 PST ---
(From update of attachment 99162)
View in context: https://bugs.webkit.org/attachment.cgi?id=99162&action=review

This patch is ready to go, but I think it's worth fixing this one last layout test issue.

> LayoutTests/fast/js/script-tests/eval-contained-syntax-error.js:11
> +	if (e.line == 6)
> +		successfullyParsed = true;
> +	else
> +		successfullyParsed = false;

This is kind of an abuse of how "successfullyParsed" is usually used in tests. "successfullyParsed" is only used to indicate whether you made it to the end of the test. To indicate success or failure of the thing you're testing, you want something like:

debug("PASS: e.line should be 6 and is.");

AND

debug("FAIL: e.line should be 6 but instead is " + e.line + ".");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.