[Webkit-unassigned] [Bug 61061] TestFailures page blames arbitrary revisions for breaking flaky tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 29 14:49:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61061





--- Comment #7 from Adam Roben (:aroben) <aroben at apple.com>  2011-06-29 14:49:48 PST ---
(From update of attachment 99100)
View in context: https://bugs.webkit.org/attachment.cgi?id=99100&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:36
>>       * Preiodically calls callback until all current failures have been explained. Callback is
> 
> Preiodically => Periodically
> 
> (Just thought to mention the misspelling even though this text isn't part of the actual changes)

I'll fix this.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:66
>>       * Each build contains just the failures that a) are still occuring on the bots, and b) were new
> 
> occuring => occurring
> 
> (Just thought to mention the misspelling even though this text isn't part of the actual changes)

I'll fix this.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:133
>> +            const minimumRequiredTestRunsWithoutInterestingChanges = 5;
> 
> Note: IE doesn't support const (*). I take it we don't expect to access this web app from IE.
> 
> (*) The decision against const support in IE9 was remarked in <http://blogs.msdn.com/b/ie/archive/2010/08/25/chakra-interoperability-means-more-than-just-standards.aspx>.

Correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list