[Webkit-unassigned] [Bug 63660] Only enable TestWebKitAPI on bots on win and mac-snowleopard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63660


Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99153|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Adam Roben (:aroben) <aroben at apple.com>  2011-06-29 14:44:25 PST ---
(From update of attachment 99153)
View in context: https://bugs.webkit.org/attachment.cgi?id=99153&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:539
> +        if configuration == "debug" and (platform == 'mac-snowleopard' or platform == 'win'):

It would be nice if we didn't have to change this line of code once we have a mac-lion bot.

The mixture of single- and double-quotes here is strange.

I'd write the second part as:  platform in ('mac-snowleopard, 'win')

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:562
> +        if configuration == "debug" and (platform == 'mac-snowleopard' or platform == 'win'):

Same comments as above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.