[Webkit-unassigned] [Bug 63582] [Qt] REGRESSION(r87797): Broke KDEWebKit's custom QNAM.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63582





--- Comment #8 from Dawit A. <adawit at kde.org>  2011-06-29 12:07:09 PST ---
(In reply to comment #7)
> (From update of attachment 99110 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99110&action=review
> 
> > Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1698
> > +    // A dynamic Qt property, _q_emitUnsupportedContentDirectly, is used here to prevent breakage
> > +    // of custom QNAM implementations that assume this signal would not be queued, e.g kdewebkit.
> 
> Why not modify kdewebkit?

How ? kdewebkit needs the notification as soon as possible and the workaround completely prevents that from happening. The fact that the notification is needed immediately is not a simple choice in kdewebkit. It is a requirement enforced on it by the design of KIO.

The way KIO 's put-slave-on-hold feature is designed, it requires the client to put the ioslave on hold as soon as it informs it of the mime-type if the client cannot handle that content-type. Otherwise, the "put-slave-on-hold" functionality will not work and the same resource would end up being downloaded at least twice: once for the original the request and the second when the application is launched to handle the request attempts to retrieve it. That won't happen if the slave is put on hold because the request the lanuched application make would be assigned to use the already parked (put-on-hold) ioslave. 

Anyhow, if the unsupported content signal is queued, the slot that handles this won't receive the notification on time to pause the ioslave. The ioslave would already been in the process of downloading the request. That not only causes the issue mentioned above, duplicate download of same resource, but since the call to publish the ioslave for reuse is a sync call, it causes a freeze in the application until the ioslave can interrupt itself from downloading the content to respond to our request.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.