[Webkit-unassigned] [Bug 63462] [EFL] Add ewk_frame_text_selection_type_get function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 29 06:15:27 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63462





--- Comment #12 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2011-06-29 06:15:26 PST ---
(From update of attachment 98929)
View in context: https://bugs.webkit.org/attachment.cgi?id=98929&action=review

>> Source/WebKit/efl/ChangeLog:9
>> +        text selection type.
> 
> No need to say 'This patch'; just begin the sentence with 'Add a method to...'.

fixed

>> Source/WebKit/efl/ewk/ewk_frame.cpp:1548
>> +    case WebCore::VisibleSelection::NoSelection:
> 
> default:

fixed

>> Source/WebKit/efl/ewk/ewk_frame.cpp:1552
>> +    return EWK_TEXT_SELECTION_NONE;
> 
> Delete this line.

fixed

>> Source/WebKit/efl/ewk/ewk_frame.h:162
>> +typedef enum _Ewk_Text_Selection_Type Ewk_Text_Selection_Type;
> 
> typedef enum { ... } Ewk_Text_Selection_Type;

fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list