[Webkit-unassigned] [Bug 63610] [NRWT] make nrwt able to test the same order like orwt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63610





--- Comment #1 from Peter Gal <galpeter at inf.u-szeged.hu>  2011-06-29 04:44:36 PST ---
(In reply to comment #0)
> Created an attachment (id=99045)
 --> (https://bugs.webkit.org/attachment.cgi?id=99045&action=review) [details]


> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:566
> +            self._tests_with_http_lock = []

This is only used in 2 places (including this one). Will this be used later?

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:570
> +            for test_file in test_files:

you can ditch the 'i' variable from above if you use 'enumerate' in the for. Like this:
 for i, test_file in enumerate(test_files):

This way you don't need to manually increment the 'i' at the end.

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:575
> +                test_by_thousand.setdefault(j, [])

I think a better place for this would be in the 'if' case were you increment the 'j' variable,
there you can simply do the following:  test_by_thousand[j] = []

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:585
> +                test_lists.append(test_list_tuple)

Could you try this?:

test_lists = [(tests, test_list) for tests, test_list in test_by_thousand.iteritems()]

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:1388
> +            if re.search('LayoutTests.http', test):

For this a simple: 'LayoutTests.http' in test  is enough no need for the re.

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:1390
> +            elif re.search('LayoutTests.websocket', test):

ditto.

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py:128
> +                    self.start_servers_with_lock()

I'm not sure but here you wanted to check if the 'list_name' is in the 'tests_with_http_lock' list?
If that's the case, then you should do it like this:

 if list_name in tests_with_http_lock:
     self.start_servers_with_lock()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.