[Webkit-unassigned] [Bug 63381] [GTK] [WK2] Implement missing initializeLogChannel function.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63381


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98589|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2011-06-28 20:08:39 PST ---
(From update of attachment 98589)
View in context: https://bugs.webkit.org/attachment.cgi?id=98589&action=review

Nice. Some comments below.

> Source/WebKit2/Platform/Logging.cpp:48
> +WTFLogChannel* getChannelFromName(const String& channelName)

Why not just put this in LoggingGtk and make it static?

> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:44
> +    // unfortunatelly this is initialized and enumerated for every WTFLogChannel

This seems like an expensive thing to do for every log channel. Why not just do it statically?

> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:45
> +    gchar** logv = g_strsplit(logEnv, " ", -1);

I would prefer you to do this with WTF::String instead of GLib. You can avoid manual memory management that way.

> Source/WebKit2/Platform/gtk/LoggingGtk.cpp:56
> +#endif /* !LOG_DISABLED */

C++ style comment here, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.