[Webkit-unassigned] [Bug 63443] [V8] Add missing compile guards for V8Proxy and V8DOMWrapper.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 17:14:19 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63443


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98702|review?                     |review-
               Flag|                            |




--- Comment #2 from Nate Chapin <japhet at chromium.org>  2011-06-28 17:14:19 PST ---
(From update of attachment 98702)
View in context: https://bugs.webkit.org/attachment.cgi?id=98702&action=review

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:53
> +#if ENABLE(FILE_SYSTEM)
>  #include "V8FileWriter.h"
> +#endif // ENABLE(FILE_SYSTEM)

#if ENABLE() shouldn't be necessary around #includes.  CodeGeneratorV8.pm should correctly putt #if ENABLE() guards around the generated binding headers.

If it isn't properly guarding the headers, we should fix the bug there. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list