[Webkit-unassigned] [Bug 63555] [Qt] GraphicsContext::clipToImageBuffer does not support scale transformation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63555


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98963|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Andreas Kling <kling at webkit.org>  2011-06-28 14:32:38 PST ---
(From update of attachment 98963)
View in context: https://bugs.webkit.org/attachment.cgi?id=98963&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

Oops indeed! The commit-queue will choke on this line, replace it with one of these three:
1) Tests: list of tests that exercise this change...
2) No new tests because...
3) Awkward silence.

> Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp:167
> +    QRectF deviceClip = context->platformContext()->transform().mapRect(floatRect);
> +    if (alphaMask.width() != deviceClip.width() || alphaMask.height() != deviceClip.height())
> +        alphaMask = alphaMask.scaled(deviceClip.width(), deviceClip.height());

We should do this in GraphicsContext::pushTransparencyLayerInternal() instead, then we avoid doing mapRect() twice, and ImageBuffer doesn't need to know about any painter transforms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.