[Webkit-unassigned] [Bug 63013] [EFL] Page Cache was not Enabled, (Enable Page Cache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63013





--- Comment #31 from DongJae, KIM <dongjae1.kim at samsung.com>  2011-06-28 14:26:32 PST ---
(In reply to comment #30)
> > Source/WebKit/efl/ChangeLog:8
> > +        1) Add contentsSize update function for cached page resotre ( ewk_view_cached_page_restore() )
> 
> resotre -> restore
> The spaces in the parentheses are not necessary.
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        2) Change return value for enable EFL Port back/forward Cache ( FrameLoaderClientEfl::canCachePage() )
> 
> Same thing about spaces.
> 
> > Source/WebKit/efl/ChangeLog:13
> > +            because, WebCore::FrameView will be create always when user go to new page.
> 
> The comma after because is not needed.
> I'd rephrase it as "WebCore::FrameView will always be created when a new page is loaded" (or opened).
> 
> > Source/WebKit/efl/ChangeLog:14
> > +            Currently, EWebLauncher browser has crashes. 
> 
> I'd rephrase this section as "This patch also ends up fixing two crashes in EWebLauncher: one when loading the 4th cached page and another triggered when a user clicks any link".
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:4502
> > +/**
> 
> Missing blank line before this. Please also add an "@internal" tag, as this function is defined in ewk_private.h

Thanks your comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.