[Webkit-unassigned] [Bug 63023] [chromium] Searching may cause a segmentation fault in WebPluginDocument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63023





--- Comment #9 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-06-28 11:38:48 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (In reply to comment #4)
> > > > (From update of attachment 97882 [details] [details] [details] [details])
> > > > View in context: https://bugs.webkit.org/attachment.cgi?id=97882&action=review
> > > > 
> > > > The fix seems right, but why no test?
> > > > 
> > > 
> > > Since this is caused by searching from the browser, this code requires Chromium to call the function which causes the segmentation fault. I do not believe that there is a way to duplicate this functionality with just HTML.
> > 
> > Could you possibly use layoutTestController.findString?
> 
> layoutTestController.findString is undefined in the chromium environment, and since this bug is in chromium code, I do not see the point in using it.

Ah! This sounds like an excellent patch then. Expose findString and write test for it using this bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.