[Webkit-unassigned] [Bug 42074] Layout problem with HTML5 menu item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42074





--- Comment #8 from Darin Adler <darin at apple.com>  2011-06-28 10:27:05 PST ---
(From update of attachment 98935)
View in context: https://bugs.webkit.org/attachment.cgi?id=98935&action=review

> Source/WebCore/html/HTMLLIElement.cpp:103
> -            if (n->hasTagName(ulTag) || n->hasTagName(olTag))
> +            if (n->hasTagName(ulTag) || n->hasTagName(olTag) || n->hasTagName(menuTag))

This change seems OK, but I am concerned that there are many other places that handle ul and ol, but not menu. I’d prefer to fix more of them.

My search show cases of this in these source files. I suspect many of these need the same fix:

accessibility/AccessibilityList.cpp
accessibility/AccessibilityRenderObject.cpp
accessibility/AXObjectCache.cpp
editing/CompositeEditCommand.cpp
editing/DeleteButtonController.cpp
editing/Editor.cpp
editing/htmlediting.cpp
editing/IndentOutdentCommand.cpp
editing/InsertListCommand.cpp
editing/markup.cpp
editing/TextIterator.cpp
rendering/RenderCounter.cpp
rendering/RenderListItem.cpp

Maybe we need a helper function to use in these places?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.