[Webkit-unassigned] [Bug 63462] [EFL] Add ewk_frame_text_selection_type_get function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63462


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98929|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #10 from Leandro Pereira <leandro at profusion.mobi>  2011-06-28 10:03:19 PST ---
(From update of attachment 98929)
View in context: https://bugs.webkit.org/attachment.cgi?id=98929&action=review

> Source/WebKit/efl/ChangeLog:9
> +        This patch adds a method to obtain current WebCore::VisibleSelection
> +        text selection type.

No need to say 'This patch'; just begin the sentence with 'Add a method to...'.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1548
> +    case WebCore::VisibleSelection::NoSelection:

default:

> Source/WebKit/efl/ewk/ewk_frame.cpp:1552
> +    return EWK_TEXT_SELECTION_NONE;

Delete this line.

> Source/WebKit/efl/ewk/ewk_frame.h:162
> +enum _Ewk_Text_Selection_Type {
> +    EWK_TEXT_SELECTION_NONE,
> +    EWK_TEXT_SELECTION_CARET,
> +    EWK_TEXT_SELECTION_RANGE
> +};
> +typedef enum _Ewk_Text_Selection_Type Ewk_Text_Selection_Type;

typedef enum { ... } Ewk_Text_Selection_Type;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.