[Webkit-unassigned] [Bug 63377] [EFL] Remove unused code related with priv->render.process_entire_queue in ewk_tiled_backing_store

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 02:02:17 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=63377





--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-06-28 02:02:16 PST ---
(In reply to comment #10)
> > Why is the cq set to cq+? That is wrong - the patch is not even reviewed yet.
> 
> I am wondering about it too. Sorry for the confusion, there might be my mistake.
> 
> > I don't understand what you are saying here, please rephrase. And please tell  why it is fine to remove that setter API?
> 
> As this field might be intended to use for updating dirty tiles in tile matrix at once, but, there was no related code with this field which can be used for any condition check or other logical flow,but, two apis (ewk_view_tiled_process_entire_queue_set, ewk_tiled_backing_store_process_entire_queue_set) that I am trying to remove are just provided as setter api for setting priv->render.process_entire_queue to TRUE or FALSE.
> So, It can be set , but it's not effective because no module is using it.

As an outsider there is no way I can know that, nor that it is OK with all EFL developers. Why was API committed anyway if it is not being used... that means that it is basically dead code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list