[Webkit-unassigned] [Bug 63229] [EFL] Add APIs to get/set view mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63229





--- Comment #20 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-06-28 01:23:47 PST ---
(From update of attachment 98871)
View in context: https://bugs.webkit.org/attachment.cgi?id=98871&action=review

> Source/WebKit/efl/ChangeLog:9
> +        This patch:
> +        - Implement view-mode property in EFL port.

Please describe it in a more natural way: Implement public API for getting/setting the view-mode media feature as specified by ...

> Source/WebKit/efl/ewk/ewk_view.cpp:4568
> +Ewk_View_Mode ewk_view_mode_get(Evas_Object* o)
> +{
> +    EWK_VIEW_SD_GET(o, sd);
> +    if (!sd)
> +        return EWK_VIEW_MODE_WINDOWED;
> +    EWK_VIEW_PRIV_GET(sd, priv);
> +    if (!priv)
> +        return EWK_VIEW_MODE_WINDOWED;
> +
> +    switch (priv->page->viewMode()) {
> +    case WebCore::Page::ViewModeFloating:
> +        return EWK_VIEW_MODE_FLOATING;
> +    case WebCore::Page::ViewModeFullscreen:
> +        return EWK_VIEW_MODE_FULLSCREEN;
> +    case WebCore::Page::ViewModeMaximized:
> +        return EWK_VIEW_MODE_MAXIMIZED;
> +    case WebCore::Page::ViewModeMinimized:
> +        return EWK_VIEW_MODE_MINIMIZED;
> +    default:
> +        return EWK_VIEW_MODE_WINDOWED;
> +    }
> +}

one is obvious default here. Why not do

Ewk_View_Mode mode = EWK_VIEW_MODE_WINDOWED;

then change all returns to "return mode" and make the switch modify mode?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.