[Webkit-unassigned] [Bug 55987] input type=email and multiple is not compliant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55987


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98855|review?                     |review+
               Flag|                            |




--- Comment #13 from Kent Tamura <tkent at chromium.org>  2011-06-27 21:56:49 PST ---
(From update of attachment 98855)
View in context: https://bugs.webkit.org/attachment.cgi?id=98855&action=review

> Source/WebCore/html/EmailInputType.h:49
> +    virtual String sanitizeValue(const String& proposedValue);

No need to write the argument name.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:72
> +    StringBuilder builder;
> +    for (unsigned i = 0; i < length; i++) {
> +        if (!isHTMLLineBreak(string[i]))
> +            builder.append(string[i]);
> +    }
> +    return builder.toString();

- You can avoid to build StringBuilder if the input string has no line breaks.
- You had better call builder.reserveCapacity(length).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.