[Webkit-unassigned] [Bug 63491] [EFL] Remove IconDatabase initialization in _ewk_init_body()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63491





--- Comment #11 from Jaehun Lim <ljaehun.lim at samsung.com>  2011-06-27 18:20:57 PST ---
(In reply to comment #9)
> (From update of attachment 98811 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98811&action=review
> 
> > Source/WebKit/efl/ChangeLog:11
> > +2011-06-27  Jaehun Lim  <ljaehun.lim at samsung.com>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        [EFL] Remove IconDatabase initialization in _ewk_init_body()
> > +        https://bugs.webkit.org/show_bug.cgi?id=63491
> > +
> > +        IconDatabase is an optional feature. But EFL port enables it in _ewk_init_body()
> > +        as default.
> > +        This patch removes IconDatabase enabling while ewk initialzation and
> > +        prevents an application from re-opening IconDatabase.
> 
> I think a better description would be:
> 
> Make IconDatabase feature optional by removing its initialization from _ewk_init_body(). Now IconDatabase must be fully managed by an application: if it doesn't want to use it, there's nothing to do. Otherwise, just call ewk_settings_icon_database_path_set() with the directory path.

I changed, thanks.

> 
> > Source/WebKit/efl/ewk/ewk_main.cpp:-201
> >          ewk_settings_web_database_path_set(wkdir.utf8().data());
> > -        ewk_settings_icon_database_path_set(wkdir.utf8().data());
> 
> What do you think about taking the same approach for web database?

I made this patch because of IconDatabase's re-opening problem. I didn't care about web database.
At a glance, it looks no problem to take the same approach. After I analyze more, I'll try to do

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.