[Webkit-unassigned] [Bug 63462] [EFL] Add ewk_frame_text_selection_type_get function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63462


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98737|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-06-27 17:41:54 PST ---
(From update of attachment 98737)
View in context: https://bugs.webkit.org/attachment.cgi?id=98737&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:1536
> +    EWK_FRAME_SD_GET_OR_RETURN(o, sd, EWK_TEXT_SELECTION_NONE);

I'm not sure if we can use above usage. There is similar usage on Bug 63229. If there are no problems, I think this usage is good.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1537
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EWK_TEXT_SELECTION_NONE);

ditto.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1541
> +        return EWK_TEXT_SELECTION_NONE;

Adhere indentation. 

if (!controller)
     return XXX

> Source/WebKit/efl/ewk/ewk_frame.cpp:1547
> +        type = EWK_TEXT_SELECTION_CARET;

Adhere indentation. We need to use 4 spaces.

case WebCore::XXX
      type = EWK_XXX

> Source/WebKit/efl/ewk/ewk_frame.cpp:1550
> +        type = EWK_TEXT_SELECTION_RANGE;

ditto.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1553
> +        type = EWK_TEXT_SELECTION_NONE;

ditto.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1555
> +    default:

ditto.

> Source/WebKit/efl/ewk/ewk_frame.h:158
> +    EWK_TEXT_SELECTION_NONE,

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.