[Webkit-unassigned] [Bug 63214] convert editing/deleting/4845371.html to runDumpAsTextEditingTest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63214





--- Comment #7 from Wyatt Carss <wcarss at chromium.org>  2011-06-27 17:06:09 PST ---
(From update of attachment 98447)
View in context: https://bugs.webkit.org/attachment.cgi?id=98447&action=review

>> LayoutTests/ChangeLog:8
>> +        Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents-expected, 
> 
> nit: delete-cell-contents.html ?

good catch!

>> LayoutTests/editing/deleting/delete-cell-contents.html:-1
>> -<p>This tests for a crasher when deleting contents of a table cell.</p>
> 
> This is not a feedback, just for asking for myself but...
> How did you make rename and modification separate change in this single patch?
> I'd like to know how to do this.

My workflow is a little convoluted.. I'm a git-user, but it doesn't like renames. So I perform a git branch and make all of the changes I wish to make other than renames, and then I 'Tools/Scripts/webkit-patch upload'. After that, I move to my parallel SVN tree and 'Tools/Scripts/webkit-patch apply-attachment' with the attachment number, perform only the renames (and update the ChangeLog), and upload the attachment again. There is likely a much more smooth way to work, but this is the pattern I've fallen into when renames come into play.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.