[Webkit-unassigned] [Bug 63482] Allow non-main thread text drawing in ICU ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63482





--- Comment #9 from Darin Adler <darin at apple.com>  2011-06-27 16:00:12 PST ---
(From update of attachment 98808)
View in context: https://bugs.webkit.org/attachment.cgi?id=98808&action=review

> Source/WebCore/platform/ThreadGlobalData.cpp:90
> +    return *m_lineBreakIteratorPool.get();

No need for the .get() here.

> Source/WebCore/platform/ThreadGlobalData.h:80
> +        OwnPtr<LineBreakIteratorPool> m_lineBreakIteratorPool;

I think you still need to set this to nullptr in destroy().

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:49
>      LineBreakIteratorPool() { }

This can be private now. Or you can remove it if you want to leave it public.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.