[Webkit-unassigned] [Bug 62916] WebCore fails to compile in thumb mode when neon instructions are enabled.

Mon Jun 27 14:35:34 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=62916

Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98444|review?                     |review-
               Flag|                            |

--- Comment #6 from Tony Chang <tony at chromium.org>  2011-06-27 14:35:34 PST ---
(From update of attachment 98444)
View in context: https://bugs.webkit.org/attachment.cgi?id=98444&action=review

Just some minor style nits.

> WebCore/ChangeLog:7
> +        enabled. There are two files (FELightingNEON.cpp and
> +        FELightingNEON.cpp) which fail to build when -mthumb is

I think you mean to mention FEGaussianBlur.cpp here.

> WebCore/WebCore.gyp/WebCore.gyp:1313
> +        ['exclude', 'platform/graphics/filters/arm/.*NEON\\.(cpp|h)'],

Nit: Sort the excludes alphabetically.  You might want to add a comment above this saying that these files are compiled into webcore_arm_neon.

> WebCore/WebCore.gyp/WebCore.gyp:1693
> +        'webcore_arm_neon',

Nit: Sort these alphabetically too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.