[Webkit-unassigned] [Bug 63409] DFG JIT does not perform put_by_id caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63409





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2011-06-27 12:12:28 PST ---
(In reply to comment #4)
> (From update of attachment 98642 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98642&action=review
> 
> Hey Filip, this patch looks great, and I'd be happy to accept as is.  I've r-ed to bounce back to you to give you a chance to look at a couple of suggestions, but feel free to consider both optional, and just reset r? on this patch if you want.  Our coding style leans against bool parameters where possible, since their meaning at the call site is often opaque, in many cases we prefer enumerated types.  In this case I'm not sure that I'd recommend adding an extra enum, so I'd either pass a function pointer or stick with the bool.

I totally agree that bool is nasty.  We already have this bool thing for direct in other places (PutPropertySlot mainly) so I followed that pattern.  But I don't particularly like it.

I'm not entirely sure I like your suggestion either; I like the notion that dfgRepatchPutByID and friends abstract away what slow-path calls they're making, as much as possible.

What about this: add an enumeration in PutPropertySlot (or some other appropriate place):

enum PutKind { Direct, NotDirect };

And replace the "bool direct" throughout with this enum?  I'd be happy to make this refactoring as part of this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.