[Webkit-unassigned] [Bug 62837] [chromium]Optimize GraphicsLayerChromium::setChildren

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62837





--- Comment #9 from Vangelis Kokkevis <vangelis at chromium.org>  2011-06-27 10:30:29 PST ---
(From update of attachment 97556)
View in context: https://bugs.webkit.org/attachment.cgi?id=97556&action=review

Thanks for the patch! This solution will fix the problem.  I do think that the GraphicsLayerChromium child management code needs some clean up and batching up pushes to the platform layers much like the CA implementation does would be nice.  However, I think this is a good intermediate solution.

> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:133
> +    m_setChildren = true;

Maybe using m_inSetChildren (instead of m_setChildren) would be more descriptive?

> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:135
>      // FIXME: GraphicsLayer::setChildren calls addChild() for each child, which

This fixme should be removed now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.