[Webkit-unassigned] [Bug 62780] Migrate SQLite backing store to LevelDB backing store for Indexeddb.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62780





--- Comment #11 from Hans Wennborg <hans at chromium.org>  2011-06-27 09:54:44 PST ---
(From update of attachment 98073)
This looks great, I only have nits left :)


View in context: https://bugs.webkit.org/attachment.cgi?id=98073&action=review

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:49
> +    return securityOrigin->databaseIdentifier() + "@" + name + String::format("@%d", type);

i think computeUniqueIdentifier could re-use computeFileIdentifier... something like

return computeFileIdentifier(...) + "@" + name

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:148
> +    // Migrate objectStores. Check to see if the object store already exists in the target

period.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:158
> +        int64_t assignedObjectStoreId=-1;

space around '=' operator

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:167
> +            keyPath = true;

I don't see keyPath actually being used anywhere.. probably a leftover from earlier version of the patch?

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:176
> +                    break;

return false?

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:191
> +                break;

return false?

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:193
> +            IDBObjectStoreBackendImpl::populateIndex(*toBackingStore, toDatabaseId, assignedObjectStoreId, indexId, fromKeyPaths[i]);

populateIndex returns a bool on failure, so let's check it

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:252
> +    int64_t toDatabaseId=-1;

space around '='

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.