[Webkit-unassigned] [Bug 63330] Concatenating wide strings and WTF::Strings using operator+ is suboptimal on MSVC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63330





--- Comment #6 from Adam Roben (:aroben) <aroben at apple.com>  2011-06-27 07:25:50 PST ---
(In reply to comment #5)
> What about non-wide strings on other platforms?

I tried compiling this in a Debug build on Mac OS X 10.6:

String color("brown");
String workEthic("lazy");
String result = "The quick " + color + " fox jumped over the " + workEthic + " dogs";

What happens is:

1. ("The quick " + color) is evaluated, resulting in a StringAppend object
2. StringAppend::operator String() is called
3. (String(L"The quick brown") + " fox jumped over the ") is evaluated, resulting in a StringAppend object
4. StringAppend::operator String() is called

...and so on.

This is also suboptimal. I believe this would also be fixed by my attached patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.