[Webkit-unassigned] [Bug 63229] [EFL] Add APIs to get/set view mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63229





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-06-27 05:57:20 PST ---
(From update of attachment 98708)
View in context: https://bugs.webkit.org/attachment.cgi?id=98708&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:4549
> +        return EWK_VIEW_MODE_INVALID;

I'm not sure if this implementation is good.  Did you test "EWK_VIEW_SD_GET_OR_RETURN(o, sd, EWK_VIEW_MODE_INVALID)" ?
If there are no problems on this implementation, I think this is better.

Lucas, can we use this implementation? It looks there is no critical problems.

> Source/WebKit/efl/ewk/ewk_view.cpp:4552
> +        return EWK_VIEW_MODE_INVALID;

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.