[Webkit-unassigned] [Bug 46152] [Chromium] Need setPrinting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 27 02:29:45 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=46152





--- Comment #2 from MORITA Hajime <morrita at google.com>  2011-06-27 02:29:45 PST ---
(From update of attachment 97851)
View in context: https://bugs.webkit.org/attachment.cgi?id=97851&action=review

Hi Stephen, 
Thank you for doing this!

Once you implement testing API, you can enable a test which is marked as to fail.
To see which test can be flipped, please see original bug.
In this case, you need to remove line "BUGWK20011 : printing/setPrinting.html = FAIL"
from LayoutTests/platform/chromium/test_expectations.txt,
run the test, and include test result in this change.

> Tools/DumpRenderTree/chromium/LayoutTestController.h:552
> +

Please don't include unnecessary change.

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1498
>          int left = max(m_paintRect.x, clientRect.x);

Please don't incude unrelated change. This kind of cleanup can be done by separate patch.
(And such kind of cleanup is highly welcome!)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list