[Webkit-unassigned] [Bug 63013] [EFL] Page Cache was not Enabled, (Enable Page Cache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63013





--- Comment #5 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-26 23:45:19 PST ---
Great, it's what I wish for a long time.
I commented small things in addition to gyuyoung's comment.

View in context: https://bugs.webkit.org/attachment.cgi?id=98662&action=review

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:607
> +    //This method must be called before WebCore::FrameView::layout()
> +    ewk_view_frame_restore_cachedpage(m_view,m_frame);

m_view, m_frame);
And is this comment necessary?

> Source/WebKit/efl/ewk/ewk_private.h:181
> +void ewk_view_frame_restore_cachedpage(Evas_Object* o, Evas_Object* frame);
> +

How do you think about moving it below of ewk_view_frame_create ?

> Source/WebKit/efl/ewk/ewk_view.cpp:4517
> +    WebCore::Frame* main_frame = ewk_frame_core_get(frame);

I think that sd already know main frame.

> Source/WebKit/efl/ewk/ewk_view.cpp:4521
> +    WebCore::HistoryItem* item = main_frame->loader()->history()->currentItem();
> +
> +    if(!main_frame)
> +        return;

It checked after using main_frame.

> Tools/EWebLauncher/main.c:279
> -    ewk_view_fixed_layout_size_set(app->browser, app->viewport.w, app->viewport.h);
> -    ewk_view_zoom_set(app->browser, app->viewport.initScale, 0, 0);
>      if (!ewk_view_zoom_range_set(app->browser, app->viewport.minScale, app->viewport.maxScale))
>          info(" Fail to set zoom range. minScale = %f, maxScale = %f\n", app->viewport.minScale, app->viewport.maxScale);
>      ewk_view_user_scalable_set(app->browser, app->viewport.userScalable);
> +
> +    ewk_view_fixed_layout_size_set(app->browser, app->viewport.w, app->viewport.h);
> +    ewk_view_zoom_set(app->browser, app->viewport.initScale, 0, 0);
> +

Can I know why you moved?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.