[Webkit-unassigned] [Bug 63409] DFG JIT does not perform put_by_id caching
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 26 14:34:06 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=63409
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com> 2011-06-26 14:34:07 PST ---
Attachment 98639 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.cpp:288: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:288: The parameter name "returnAddress" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:305: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:305: The parameter name "returnAddress" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:322: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:322: The parameter name "returnAddress" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:339: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:339: The parameter name "returnAddress" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGRepatch.cpp:53: One line control clauses should not use braces. [whitespace/braces] [4]
Source/JavaScriptCore/dfg/DFGRepatch.cpp:55: One line control clauses should not use braces. [whitespace/braces] [4]
Source/JavaScriptCore/dfg/DFGRepatch.cpp:102: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/JavaScriptCore/dfg/DFGRepatch.cpp:107: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 12 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list