[Webkit-unassigned] [Bug 63392] Indirectly including TextPosition.h and XPathGrammar.h causes compile errors

Sun Jun 26 11:20:52 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=63392

--- Comment #6 from Adam Barth <abarth at webkit.org>  2011-06-26 11:20:52 PST ---
> Do we have a real need to have both numbering systems in core code, not just when displaying a position in Web Inspector? That seems unlikely.

I don't see how to avoid this issue.  If you see how to avoid it, please let the rest of us know.

> C++ type safety only comes into play when assigning from one TextPosition to another, so off by one errors will still be likely when converting to or from integers anyway.

Indeed.  However, these values get passed around a bunch of places and it's helpful to keep track of whether they're one-based or zero-based.

> I don't think that I'm supposed write a patch for every design/review failure that I see.

You're claiming this machinery isn't needed, but I suspect you don't understand the design pressures that lead to its creation.  If you see a way to remove it, I'd be more than happy to review such a ptach.  I don't see how to do it, which is why we have these types.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.