[Webkit-unassigned] [Bug 63392] Indirectly including TextPosition.h and XPathGrammar.h causes compile errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63392


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|JavaScriptCore              |WebKit Misc.
                 CC|                            |abarth at webkit.org,
                   |                            |ap at webkit.org,
                   |                            |caseq at chromium.org
     Ever Confirmed|0                           |1




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2011-06-26 00:22:25 PST ---
We use all-uppercase words for macros, so TextPosition.h is indeed wrong using it as template parameter. A similar problem exists in InspectorValues.cpp.

TextPosition has a ton of problems - from a bad name to a huge number of style errors in its code. Supporting both 1-based and 0-based offsets is a particularly bad idea - and that's why the class is templatized in the first place. It shouldn't have passed review in its current form.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.