[Webkit-unassigned] [Bug 53627] Inspector highlight rect is wrong for contents of transformed iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53627


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98577|review?                     |review+
               Flag|                            |




--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-06-25 09:20:39 PST ---
(From update of attachment 98577)
View in context: https://bugs.webkit.org/attachment.cgi?id=98577&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2747
> +    mapLocalToContainer(repaintContainer, false, false, transformState, 0);

You should give wasFixed a default value of 0 to avoid having to do this.

> Source/WebCore/rendering/RenderBox.h:433
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool fixed, bool useTransforms, TransformState&, bool* wasFixed) const;

use wasFixed = 0 here.

> Source/WebCore/rendering/RenderInline.h:133
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool fixed, bool useTransforms, TransformState&, bool* wasFixed) const;

And here.

> Source/WebCore/rendering/RenderObject.h:774
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState&, bool* wasFixed) const;

And here.

> Source/WebCore/rendering/RenderView.h:167
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState&, bool* wasFixed) const;

You get the drill.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.