[Webkit-unassigned] [Bug 63348] Bugs filed from TestFailures page should include links to Trac for suspect revisions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63348





--- Comment #4 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-06-24 13:50:28 PST ---
(In reply to comment #3)
> (From update of attachment 98529 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review
> 
> >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309
> >> +                endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';
> > 
> > Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth.
> 
> I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like:
> 
> foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>.

Sorry, I thought it was doing something like this:

r<a href="http://trac.webkit.org/changeset/12345">12345</a>

That's fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.