[Webkit-unassigned] [Bug 61699] Multiple failures in css2.1/t1504-c543-txt-decor-00-d-g.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 24 10:46:57 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61699





--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2011-06-24 10:46:57 PST ---
Hey! Thanks for taking a look. I stick by what I said. The test says that
there should be an underline under the images, but there is not. So to
answer you questions:

> 1. did we check-in incorrect -expected file for this test?

Yes, it appears so. Probably so that the test did not show up as Red/Yellow on the bots. Failures are often checked in, with bugs filed, so that the bots are green and the issue is tracked. I did not see a bug filed on this issue, so I opened this one. Another temporary solution is to skip the test.

> 2. If no then the present issue cannot be treated as a BUG as far as content is concerned, which is what you have described.

I don't quite follow. Its not always the case that checked in expected results are perfect. Due to accidents, or attempts to keep the bots green failing results are sometimes checked in. I don't have any specific examples right now to support this though.

> 3. In such a case the only buggy behaviour i see between -expected.png and -actual.png file is some off-set in the lay-out w.r.t each line of output.

I was not seeing an issue between expected/actual. I was just seeing an issue with the expected. The checked in expected results DO NOT match what the test says it is trying to do. This bug tracks investigating why.

To move this bug forward:

  • Are the expected results actually correct?
    -> Yes. Make a comment in the test saying "the test was wrong in this regard...."
       so that other people that come across this don't get tripped up.
    -> No. Fix it!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list