[Webkit-unassigned] [Bug 63064] Apply the ParallelJobs support to FEMorphology

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63064





--- Comment #7 from Zoltan Herczeg <zherczeg at webkit.org>  2011-06-24 04:18:52 PST ---
(From update of attachment 98477)
View in context: https://bugs.webkit.org/attachment.cgi?id=98477&action=review

> Source/WebCore/platform/graphics/filters/FEMorphology.h:73
> +        static inline void platformApplyWorker(PlatformApplyParameters*);

This function cannot be inline, since called by pointer. Probably the compiler realises this anyway, but still it would be better to remove it.

> Source/WebCore/platform/graphics/filters/FEMorphology.h:76
> +        inline void platformApply(PaintingData*, const int radiusX, const int radiusY);

Ok, this is still bad. Maybe I was not clear last time.

platformApply should get only 1 parameter: PaintingData*
radiusX and radiusY should go to PaintingData as the width and height

The calculation should be paintingData.radiusX = min(effectDrawingRect.width() - 1, radiusX);, since otherwise the plain radiusX would be an unused parameter.

Drop these lines: int radiusX = static_cast<int>(floorf(filter()->applyHorizontalScale(m_radiusX))); and radiusY = ...
I am not even sure this is correct...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.