[Webkit-unassigned] [Bug 63256] [GTK] Fix runtime critical warnings in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63256





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-06-24 00:28:14 PST ---
(In reply to comment #2)
> (From update of attachment 98350 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98350&action=review
> 
> > Source/WebCore/platform/gtk/PlatformScreenGtk.cpp:92
> > -FloatRect screenRect(Widget* widget)
> > +static gboolean getScreenAndMonitorForWidget(Widget* widget, GdkScreen** screenOut, gint* monitorOut)
> 
> I'd rather this be a smaller helper (getScreen) like getVisual.

The problem is that screenRect needs the toplevel widget to get monitor, so if we only return the screen, we need to get the toplevel again to get the monitor. That's why I added a function to get both the screen and monitor.

> In fact, getVisual should just use this helper to get the screen.

getVisual() doesn't need the screen, only when there's no widget, but in that case it uses the default screen to return the system visual.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.