[Webkit-unassigned] [Bug 63044] [EFL] Makes themeForPage() return static RenderThemeEfl.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63044





--- Comment #11 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-23 18:05:54 PST ---
(In reply to comment #10)
> > BTW, ewk_frame_theme_set/get should be removed.
> > It looks meaningless regardless of this patch.
> 
> I don't understand why we should remove the ewk_frame_theme_set/get. 
> 
> Do you mean the ewk_frame_theme_set/get implementation can be moved to ewk_view_theme_set/get ? As you know, ekw_view_theme_set/get call the functions. Although efl port has one theme now, EWebLauncher is using the ewk_view_theme_set.

Right, ewk_frame_theme_set should be merged into ewk_view_theme_set.
Although we set theme to FrameView, we can't get different theme because WebCore::Page have only one RenderTheme.

But ewk_view_theme_set is reasonable now because each ewk_view have own WebCore::Page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.